Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8606 )
Change subject: tablet: add early returns to maintenance functions ...................................................................... tablet: add early returns to maintenance functions When a Tablet is stopped, further maintenance ops are not scheduled, further IO is prevented, etc. This patch optimizes this further to stop various functions that are called by maintenance threads to prevent their execution, returning an error instead. Previously, certain ops (e.g. flush DMS) would guarantee durability by checking for the success these functions. These checks are now replaced with on-error checks that the tablet has been stopped, since these failures are inconsequential if the tablet is stopped. Currently this is an optimization for tablets that are shutting down to return early from these calls, but in the future, this could be useful in stopping all IO done by a tablet that is failing, e.g. due to disk failure. Change-Id: I84ad557851863f6fd9acff28ddcd1244e62cf516 Reviewed-on: http://gerrit.cloudera.org:8080/8606 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/integration-tests/stop_tablet-itest.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/tablet_replica_mm_ops.cc 5 files changed, 34 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I84ad557851863f6fd9acff28ddcd1244e62cf516 Gerrit-Change-Number: 8606 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
