Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 )
Change subject: [spark] add 'local-cluster' mode for unit test ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8585/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala: http://gerrit.cloudera.org:8080/#/c/8585/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala@69 PS1, Line 69: testMode.toLowerCase > I want to do a toLowerCase here, that is why I have the extra null checking sorry for the incomplete sentence. Complete it here: "But do you think a lower case support is necessary?" -- To view, visit http://gerrit.cloudera.org:8080/8585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07b2daad6f6883eb7425fa7132208818bbe65788 Gerrit-Change-Number: 8585 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 22 Nov 2017 20:32:26 +0000 Gerrit-HasComments: Yes
