Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 )
Change subject: make registration of maintenance ops thread-safe ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8635/1/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/8635/1/src/kudu/tablet/tablet_replica.cc@693 PS1, Line 693: if (tablet) why "if" ? Is it possible for RegisterMaintenanceOps() to be called after TabletReplica:;Stop() now? http://gerrit.cloudera.org:8080/#/c/8635/1/src/kudu/tablet/tablet_replica.cc@703 PS1, Line 703: UnregisterMaintenanceOps is it possible for multiple threads to call this function simultaneously? if so, then we could have a use-after-free -- To view, visit http://gerrit.cloudera.org:8080/8635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13051fab85d0f678bd3efdcb69766d66a657cdd Gerrit-Change-Number: 8635 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 00:38:23 +0000 Gerrit-HasComments: Yes
