Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8642 )
Change subject: KUDU-1097 (patch1): test for replica health reporting ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/8642/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/8642/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@362 PS1, Line 362: eports. > This does not make much sense because this closure is never invoked with tw I see default param as nullptr as documentation that the arg is optional but I'm ok with this http://gerrit.cloudera.org:8080/#/c/8642/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@476 PS1, Line 476: map<string, HealthReportPB> reports; : NO_FATALS(get_health_reports(&reports)); > I saw that's how it's done in TsTabletManagerITest::TestReportNewLeaderOnLe I'm not sure it's truly safe but maybe it's safe enough for this kind of test... I don't see how ASSERT_EVENTUALLY would be brittle but I can live with it http://gerrit.cloudera.org:8080/#/c/8642/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@489 PS1, Line 489: he scenario below assumes the leader replica doe > It's a constructor for a reference. There is no difference here -- in both I don't think that's true. The copy constructor will get invoked and the instance will be assigned to a temporary and "report" will act as a reference to that temporary. Actually I guess this part of C++ is a bit magical for me. const string& s = "blah" should act the same way. That said, it's a test and not a very big deal. -- To view, visit http://gerrit.cloudera.org:8080/8642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62b49efebad9a123eec51dd302e375e46e0682d Gerrit-Change-Number: 8642 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 05:58:27 +0000 Gerrit-HasComments: Yes
