Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8643

to review the following change.


Change subject: consensus: Rename ChangeConfigType enum constants
......................................................................

consensus: Rename ChangeConfigType enum constants

Since we now have attributes in the RaftConfigPeerPB message, it would
be more useful to allow a peer to be modified such that only its
attributes change, but not its member type. In order to provide
meaningful semantics, that means we should change the constant name for
the "modify peer" operation as well. This patch changes
CHANGE_REPLICA_TYPE to MODIFY_PEER, and removes the requirement that the
member type change when modifying the peer.

While we're in there, let's also rename the other constants to more
accurately reflect the terminology we tend to use in this part of the code.

There are no wire-incompatible changes in this patch.

Change-Id: I77b838f1b7ddcf176d1a5146e04fa1fddc1042fa
---
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/master/catalog_manager.cc
M src/kudu/tools/tool_action_tablet.cc
6 files changed, 29 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/8643/1
--
To view, visit http://gerrit.cloudera.org:8080/8643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77b838f1b7ddcf176d1a5146e04fa1fddc1042fa
Gerrit-Change-Number: 8643
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>

Reply via email to