Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 )
Change subject: disk failure: itest for tablet copies ...................................................................... Patch Set 3: Code-Review+1 (3 comments) looks good, just nits http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@346 PS3, Line 346: don't nit: don't crash http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@357 PS3, Line 357: cluster_->tablet_server(0) nit: ext_ts0 http://gerrit.cloudera.org:8080/#/c/8636/3/src/kudu/integration-tests/tablet_copy_client_session-itest.cc@364 PS3, Line 364: unique_ptr<ExternalMiniClusterFsInspector> inspect( : new ExternalMiniClusterFsInspector(cluster_.get())); we already get one of these for free from the base class and it's named inspect_ -- To view, visit http://gerrit.cloudera.org:8080/8636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a05580d92eb4b4e73e3e940ddbb2869df063eec Gerrit-Change-Number: 8636 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 23:25:47 +0000 Gerrit-HasComments: Yes
