Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8671 )

Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster
......................................................................


Patch Set 1:

> > Patch Set 1:
 > >
 > > > > squash this into a test that needs it?
 > >  >
 > >  > This is not exactly a requirement for particular test, it's
 > more a
 > >  > convenience update for already existing tests.  I think it's
 > easier
 > >  > to track and review with in a separate changelist, if you
 > don't
 > >  > mind.
 > >
 > > And the new tests are about to benefit the new signature of the
 > utility function, resulting in less lines of the code.
 >
 > If you don't need this yet, I'd rather prioritize reviewing other
 > stuff until we need this if that's alright

Sure, it's not a priority, just a small clean-up.


--
To view, visit http://gerrit.cloudera.org:8080/8671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc
Gerrit-Change-Number: 8671
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 01:28:33 +0000
Gerrit-HasComments: No

Reply via email to