Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8675 )
Change subject: KUDU-1097: scenario for fallen-behind-the-WAL replica ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG@7 PS3, Line 7: WIP [itests] more tests for 3-4-3 re-replication > update commit message Done http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc@622 PS3, Line 622: // TODO(aserbin): clarify how to deal with the case below: it seems > mind splitting this into a separate patch? Done http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1310 PS3, Line 1310: //NO_FATALS(cluster_->AssertNoCrashes()); > remove this? Done http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1317 PS3, Line 1317: TEST_F(RaftConsensusNonVoterITest, DISABLED_FailedTabletCopyAllServers) { > mind splitting this into a separate patch? Done http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc@3154 PS3, Line 3154: if (FLAGS_raft_prepare_replacement_before_eviction) { > we should only do this if we're adding a NON_VOTER right -- good catch! -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Wed, 29 Nov 2017 10:02:07 +0000 Gerrit-HasComments: Yes
