Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8680 )
Change subject: KUDU-1097. Never evict a leader ...................................................................... Patch Set 2: (2 comments) looks good, just some nits http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@628 PS2, Line 628: const string& node : nit (just for better readability): const auto& leader_node: http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@629 PS2, Line 629: RaftConfigPB config; : AddPeer(&config, nodes[0], V, '+'); : AddPeer(&config, nodes[1], V, '+'); : AddPeer(&config, nodes[2], V, '+'); : AddPeer(&config, nodes[3], V, '+'); nit: move this out of the loop -- this part is static. -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 29 Nov 2017 20:32:19 +0000 Gerrit-HasComments: Yes
