Mike Percy has posted comments on this change. (
http://gerrit.cloudera.org:8080/8708 )
Change subject: consensus: Make queue more debuggable
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
>
> How's the overlap of the queue_state with what's already dumped to html?
the queue state is what gets dumped when you become leader and it's just a
laundry list of queue items like majority replicated index and stuff like that.
string PeerMessageQueue::QueueState::ToString() const {
return Substitute("All replicated index: $0, Majority replicated index: $1, "
"Committed index: $2, Last appended: $3, Last appended by leader: $4,
Current term: $5, "
"Majority size: $6, State: $7, Mode: $8$9",
all_replicated_index, majority_replicated_index,
committed_index, OpIdToString(last_appended),
last_idx_appended_to_leader, current_term,
majority_size_, state, (mode == LEADER ? "LEADER" : "NON_LEADER"),
active_config ? ", active raft config: " +
SecureShortDebugString(*active_config) : "");
}
http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc@131
PS1, Line 131: );
> nit: previous line? Or is this stylistic
ah, yeah, mistake. will fix
--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:37:09 +0000
Gerrit-HasComments: Yes
