Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8709 )
Change subject: KUDU-2230: the leader is always a viable voter ...................................................................... KUDU-2230: the leader is always a viable voter While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(), assume that the leader is always a viable voter. Prior to this patch, the leader itself was not counted as a viable voter since the leader does not update its own last_communication_time. Both test scenarios TestDontEvictIfRemainingConfigIsUnstable_NodesDown and TestDontEvictIfRemainingConfigIsUnstable_NodesStopped of the TabletReplacementITest test have been modified to cover the fixed issue. I verified that commenting out the fix in consensus_queue.cc makes them fail. Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c Reviewed-on: http://gerrit.cloudera.org:8080/8709 Reviewed-by: Mike Percy <mpe...@apache.org> Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/consensus/consensus_queue.cc M src/kudu/integration-tests/tablet_replacement-itest.cc 2 files changed, 83 insertions(+), 34 deletions(-) Approvals: Mike Percy: Looks good to me, approved Andrew Wong: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/8709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c Gerrit-Change-Number: 8709 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
