Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8739 )
Change subject: web_ui: don't report failed tombstones as live ...................................................................... web_ui: don't report failed tombstones as live Previously, the logic to determine the liveness of a tablet in the web UI was to check that the replica's state message was exactly "TABLET_DATA_TOMBSTONED". For failed, tombstoned replicas, this message is "FAILED(TABLET_DATA_TOMBSTONED)", and as such, these replicas were being reported as live, failed tablets (scary!). This patch adjusts the logic to instead search for "TABLET_DATA_TOMBSTONED" in the message, which should be relatively short anyway. I considered actually using the replicas' internal 'state_' members, but felt that this is more appropriate considering it'd be debatable how to report STOPPING or FAILED tablets. A test is added to tablet_server-test that fails without the fix. Change-Id: I3529c32296b555d59ddde2593360b3b66081ba4b Reviewed-on: http://gerrit.cloudera.org:8080/8718 Reviewed-by: Mike Percy <mpe...@apache.org> Tested-by: Mike Percy <mpe...@apache.org> Reviewed-on: http://gerrit.cloudera.org:8080/8739 Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Andrew Wong: Looks good to me, approved Mike Percy: Verified Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I3529c32296b555d59ddde2593360b3b66081ba4b Gerrit-Change-Number: 8739 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
