Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 )
Change subject: KUDU-2228: Make Messenger options configurable ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.cc@124 PS3, Line 124: std::string sasl_proto_name Seems more consistent to copy here too like other functions unless there is a reason not to. -- To view, visit http://gerrit.cloudera.org:8080/8789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba Gerrit-Change-Number: 8789 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 08 Dec 2017 08:42:12 +0000 Gerrit-HasComments: Yes