Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 )
Change subject: KUDU-2228: Make Messenger options configurable ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/rpc/sasl_common.cc@272 PS7, Line 272: DCHECK_EQ(kerberos_enabled, is_kerberos_enabled); > I looked into this, turns out it's caused by SaslInit() calls from client_n Thanks. I made both the above changes and the failing tests seem to pass now. http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/security/security_flags.h File src/kudu/security/security_flags.h: http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/security/security_flags.h@32 PS7, Line 32: class > nit: maybe, switch to struct since this does not have anything private/prot Done http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/security/security_flags.h@34 PS7, Line 34: const char* > nit: const char* const ? Done http://gerrit.cloudera.org:8080/#/c/8789/7/src/kudu/security/security_flags.h@35 PS7, Line 35: const char* > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/8789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba Gerrit-Change-Number: 8789 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 13 Dec 2017 15:40:25 +0000 Gerrit-HasComments: Yes
