Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 )
Change subject: [docs] Add scaling guide ...................................................................... Patch Set 1: (16 comments) New rendering: https://github.com/wdberkeley/kudu/blob/scalingguide/docs/scaling_guide.adoc http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc File docs/scaling.adoc: http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@1 PS1, Line 1: [[scaling]] > name this file scaling_guide.adoc for SEO reasons Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@2 PS1, Line 2: Scaling > Scaling Guide Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@13 PS1, Line 13: > Add a blurb at the top of this document describing the purpose of the docum Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@46 PS1, Line 46: / > nit: missing space before slash s|/|per|g http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@57 PS1, Line 57: Memory > Memory Consumption? The section titles name the resource being examined: Memory, File Descriptors, Threads; they could equally be the Memory Consumption, File Descriptor Consumption, Thread Consumption, or s/Consumption/Usage/g, but I don't want to be inconsistent and have e.g. "Memory Consumption" but then "Threads". Which variation do you prefer? http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@61 PS1, Line 61: baseline > rough estimate The full phrase would be "provides a rough estimate for computing an appropriate memory limit", which doesn't sound like a correct use of the noun "estimate" to me since the "estimate" here is a table, not a number plugged in to a formula. Maybe you'd prefer "The following table provides numbers that can be used to compute a rough estimate of memory usage"? http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@62 PS1, Line 62: limit > approximate memory requirements N/A b/c whole sentence was changed. http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@66 PS1, Line 66: Scaling > Is scaling the right word here? I think it's an appropriate word, since the values in this column describe how a measure of size multiplies into a measure of resources used, but maybe it's not "le mot juste". I'll try out another :) http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@68 PS1, Line 68: / > Here and below, i mentally read this as "divided by" when you mean "per". I Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@68 PS1, Line 68: Data on disk > "Memory required per TB of data on disk" ? Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@95 PS1, Line 95: Verifying a Memory Limit > Verifying if the memory limit is sufficient? Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@129 PS1, Line 129: | File cache | 40% of process maximum | Percentage of maximum allowed open fds reserved for use by > can we indicate how this can be tuned? Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@133 PS1, Line 133: / > per Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@150 PS1, Line 150: / cold replica > how about: * 1600 cold replicas Done http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@151 PS1, Line 151: | 200 hot replicas | 2 / segment * 10 segments/hot replica * 200 hot replicas + 1 / index * 10 indices / hot replica * 200 hot replicas = 6000 fds > having a hard time parsing this expression; consider writing it like (2 fds I thought we chatted about this and the conclusion was that there's more or less 1 index / segment. http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@183 PS1, Line 183: / > per I prefer the / when doing a calculation. -- To view, visit http://gerrit.cloudera.org:8080/8842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38d8999addc41fe0b726342a27dbba199ddf7dd2 Gerrit-Change-Number: 8842 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2017 16:11:41 +0000 Gerrit-HasComments: Yes
