Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8892 )

Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8892/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/8892/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@842
PS4, Line 842:     assertTrue("Unexpected exception:\n" + exception_text,
             :                !exception_text.contains("Exception") ||
             :                    exception_text.contains("connection 
disconnected"));
I'm a late here, but just to clarify.

Might it happen that some other exception along with 'connection disconnected' 
happens there?  If so, would this check hide that?



--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 21 Dec 2017 21:33:00 +0000
Gerrit-HasComments: Yes

Reply via email to