Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8908 )
Change subject: KUDU-2236 pt 2: fix flake in TestKuduClient ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8908/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/8908/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@845 PS1, Line 845: exception_text.contains("RecoverableException: connection closed") || > Did you get a chance to loop the test before and after this patch? I recall Yeah, it's because the previous patch was not very strict with what it would allow. E.g. I tried doing something silly: assertTrue(cla.getAppendedText().contains("connection disconnected") // i.e. no exceptions This actually passed, because "connection disconnected" gets logged a lot, vs "RecoverableException: connection disconnected", which is much more uncommon. This patch still passes 1000/1000, but with stricter conditions. -- To view, visit http://gerrit.cloudera.org:8080/8908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aafdc0eca00e743048ecc099dcb3241ce7ac8ad Gerrit-Change-Number: 8908 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2017 01:58:46 +0000 Gerrit-HasComments: Yes
