Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8911 )
Change subject: Add 'kudu fs list' tool ...................................................................... Patch Set 2: (2 comments) Actively ignoring the ColumnId copying hints, since ColumnId is trivially copyable and smaller than a pointer. http://gerrit.cloudera.org:8080/#/c/8911/1/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/8911/1/src/kudu/tools/tool_action_fs.cc@99 PS1, Line 99: using cfile::ReaderOptions; > warning: using decl 'ColumnDataPB' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8911/1/src/kudu/tools/tool_action_fs.cc@567 PS1, Line 567: // repeatedly to build up a row. > warning: the const qualified parameter 'columns' is copied for each invocat Done -- To view, visit http://gerrit.cloudera.org:8080/8911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5a63e636d95e3ee55bb4955cece7f5d0b7532d Gerrit-Change-Number: 8911 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2017 08:01:35 +0000 Gerrit-HasComments: Yes
