Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8863 )

Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................


Patch Set 2: Code-Review+1

(4 comments)

looks good, I just have nit feedback

http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:

http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@286
PS2, Line 286: is not
nit: are not (here and below)


http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@287
PS2, Line 287:
nit: the (here and below)


http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@796
PS2, Line 796:
nit: a


http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@797
PS2, Line 797: Voter
nit: Voters



--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Fri, 22 Dec 2017 21:01:53 +0000
Gerrit-HasComments: Yes

Reply via email to