Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8883 )
Change subject: [raft] Add an EmulateElection variant that waits for one more commit ...................................................................... Patch Set 2: Code-Review-1 Why can't the fuzz-test just implement this check itself? I'm not convinced this belongs in the core RaftConsensus class. If it really belongs in the RaftConsensus, then it needs finer granularity retries (such as exponential backoff with a max) and it needs a timeout instead of being possible to sit in an infinite loop. Also, the successful return condition should be that the latest op in the log has a term greater than or equal to the term assumed by the new leader. -- To view, visit http://gerrit.cloudera.org:8080/8883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4815abf09d298f227ffe57b68d5b429c43c1d69b Gerrit-Change-Number: 8883 Gerrit-PatchSet: 2 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Sun, 24 Dec 2017 18:40:58 +0000 Gerrit-HasComments: No
