David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_OWN_WRITES mode ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc@1194 PS1, Line 1194: TestBoundedScan rename this test? http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc@1199 PS1, Line 1199: KuduScanner scanner(client_table_.get()); : ASSERT_OK(scanner.SetReadMode(KuduScanner::READ_OWN_WRITES)); : ASSERT_OK(scanner.Open()); : uint64_t count = 0; : : // Do a BOUNDED_READ scan : KuduScanBatch batch; : while (scanner.HasMoreRows()) { : ASSERT_OK(scanner.NextBatch(&batch)); : count += batch.NumRows(); : } : : ASSERT_EQ(FLAGS_test_scan_num_rows, count); this doesn't strike me as a very good test, particularly if we make this mode the new default. is there something adversarial we can do to make sure your mode is working? -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 02 Jan 2018 22:38:07 +0000 Gerrit-HasComments: Yes
