Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 )
Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo ...................................................................... Patch Set 6: I changed the asserts and expects to checks, and it didn't have much of an effect. The slowness appears to be specific to TSAN. I'm able to repro the scan timing out (120s+) on a fast machine (va1022), whereas the scans take 2s and 7s with release and debug builds, respectively. Any thoughts on why TSAN may be slow in particular? Next I'm going to verify that the scans are actually completing given a much longer timeout. -- To view, visit http://gerrit.cloudera.org:8080/8951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74975cdab605b51617d93d1ae98ef72ce87e35cb Gerrit-Change-Number: 8951 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 20:07:09 +0000 Gerrit-HasComments: No
