Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8999 )
Change subject: data_dirs: fix logging message ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8999/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8999/1//COMMIT_MSG@10 PS1, Line 10: > Nit: got an extra space here Done http://gerrit.cloudera.org:8080/#/c/8999/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/8999/1/src/kudu/fs/data_dirs.cc@834 PS1, Line 834: LOG(INFO) << Substitute(msg); > Why INFO and not WARNING? At first thought, WARNING didn't seem appropriate because this doesn't necessarily point to anything "wrong". E.g. if the default were 3, it would spew warnings by default in clusters configured with 1 data dir. I suppose it could indicate a improper configuration, but given the upcoming new default behavior, I thought INFO would be more appropriate. -- To view, visit http://gerrit.cloudera.org:8080/8999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8135e0ad2411524fcb74b3e349bea7a5828a4237 Gerrit-Change-Number: 8999 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 10 Jan 2018 22:45:22 +0000 Gerrit-HasComments: Yes
