Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8996
to look at the new patch set (#2).
Change subject: [tls_socket-test] fix test to pass at Ubuntu 16.04
......................................................................
[tls_socket-test] fix test to pass at Ubuntu 16.04
Prior to this fix, the TlsSocketTest.TestNonBlockingWritev test failed
on Ubuntu 16.04 (kernel 4.4.0). After some investigation, it turned
out that setting socket send buffer size for something lower than MTU
triggers the delayed acknowledgement logic to send ack for received
data after 40ms timeout. Since the test passes big chunks of data
(32MB on every iteration), with 40ms delay for almost every 16KB sent,
the test eventually timed out. I verified that disabling the delayed
TCP ack for TLS sockets fixed the issue.
I think that the proper fix is to remove the custom setting for the
socket send buffer: a 32MB chunk of data is big enough to not fit into
the socket buffer of the default size.
Also, it seems this issue is not going to bite us in real life since
we don't set the size of the socket send buffer anywhere.
NOTE: however, some mystery is left since the failing test would pass
if running under strace.
Change-Id: I94170d5bdbe17a5952a82faf74d8b868b42460aa
---
M src/kudu/security/tls_socket-test.cc
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8996/2
--
To view, visit http://gerrit.cloudera.org:8080/8996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94170d5bdbe17a5952a82faf74d8b868b42460aa
Gerrit-Change-Number: 8996
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
