Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8920
to look at the new patch set (#2).
Change subject: Move configuration keys into its own class and make public
......................................................................
Move configuration keys into its own class and make public
External applications using the kudu-mapreduce package need to set
these configuration properties correctly. Usually they are set in the
JobConfiguration entity of a mapreduce job. For this, it is highly
preferable to have access to the config keys as they were defined
within the kudu-mapreduce package instead of redefining them within
the application (reduces duplication and potential for errors)
Since InputFormat and OutputFormat use some similar keys (and actually
used to use slightly different property names for the same thing in the
past) this commit moves all configuration keys into a common class and
makes them public for access.
Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
---
A
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduMapReduceConstants.java
M
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M
java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M
java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
6 files changed, 106 insertions(+), 85 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8920/2
--
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente <clemens.valie...@gmail.com>
Gerrit-Reviewer: Clemens Valiente <clemens.valie...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
