Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9004 )
Change subject: KUDU-2254: Detect and warn about misusage of KuduContext ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9004/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9004/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@91 PS1, Line 91: val Log: Logger = LoggerFactory.getLogger(classOf[KuduContext]) The logger inside the object on line 316 should be available here. 'val' fields inside the object (as opposed to the class) are Scala's version of static fields, so that's why we prefer that. http://gerrit.cloudera.org:8080/#/c/9004/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@94 PS1, Line 94: val taskContext = TaskContext.get mark this private[kudu] -- To view, visit http://gerrit.cloudera.org:8080/9004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65a7cd11a14fa8a668079b0d1fcf6ed3a34fb652 Gerrit-Change-Number: 9004 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 11 Jan 2018 17:49:21 +0000 Gerrit-HasComments: Yes
