Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 )
Change subject: [WIP]KUDU-1704: add java client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@132 PS1, Line 132: * Reads in this mode are not repeatable: two stale reads, even if they : * provide the same propagated timestamp bound, can execute at different : * timestamps and thus return inconsistent results. However, it allows : * read-your-writes for each client, as the picked timestamp must be higher : * than the one of the last write or read, known from the propagated timestamp. > let's reword this according to what we discussed in the other patch Done http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@138 PS1, Line 138: * In ACID terms this corresponds to Isolation mode: "Read Committed" > This isn't true, is it? Done http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@986 PS1, Line 986: testScanOwnSyncWrites > nit: testReadOwnWritesSync? Done -- To view, visit http://gerrit.cloudera.org:8080/8847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6239521c022147257859e399f55c6f3f945af465 Gerrit-Change-Number: 8847 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 12 Jan 2018 03:41:54 +0000 Gerrit-HasComments: Yes
