Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 )
Change subject: build: Move fake XML file generation to run-test.sh ...................................................................... Patch Set 3: (1 comment) I can think of another reason why it may have been done in build-and-test.sh: during precommit, run-test.sh is run on individual distributed test slaves rather than the orchestrating Jenkins slave. Could you check that "generated" JUnit XML files make their way from dist-test slaves back to the orchestrator? http://gerrit.cloudera.org:8080/#/c/8984/3/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/8984/3/build-support/run-test.sh@221 PS3, Line 221: if [ ! -f "$XMLFILE" ]; then Should this be conditioned on STATUS != 0? -- To view, visit http://gerrit.cloudera.org:8080/8984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac Gerrit-Change-Number: 8984 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 16 Jan 2018 19:37:53 +0000 Gerrit-HasComments: Yes
