Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root ...................................................................... mini-cluster: rename data_root to cluster_root I found that the name data_root for the root directory in which to place the cluster's data and logs was a confusing name because: 1. we use "data" here loosely to describe any old bytes, encompassing not only data blocks, but WALs and logs as well, and 2. the concept of a "data root" already exists to mean a user-specified location to place data blocks (i.e. an entry in fs_data_dirs). As such, this patch renames External- and InternalMiniClusterOptions' "data_root" members to "cluster_root". Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3 Reviewed-on: http://gerrit.cloudera.org:8080/9033 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/benchmarks/tpch/tpch1.cc M src/kudu/benchmarks/tpch/tpch_real_world.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/mini-cluster/internal_mini_cluster.cc M src/kudu/mini-cluster/internal_mini_cluster.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_test.cc 10 files changed, 42 insertions(+), 42 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Andrew Wong: Verified -- To view, visit http://gerrit.cloudera.org:8080/9033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3 Gerrit-Change-Number: 9033 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins