Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 )
Change subject: [rpc] don't issue authn tokens over non-confidential connections ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9025/1/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: http://gerrit.cloudera.org:8080/#/c/9025/1/src/kudu/rpc/negotiation.cc@224 PS1, Line 224: (conn->socket()->IsLoopbackConnection() && !FLAGS_rpc_encrypt_loopback_connections)); > This LGTM. I originally expected it would just be So, the way it's done in this code looks good to you, right? I just want to make sure I don't miss anything here. -- To view, visit http://gerrit.cloudera.org:8080/9025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie31aa492bcc460dbd43975bccfe571354f3bf885 Gerrit-Change-Number: 9025 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 19:32:12 +0000 Gerrit-HasComments: Yes
