Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 )
Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/common/schema-test.cc File src/kudu/common/schema-test.cc: http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/common/schema-test.cc@112 PS11, Line 112: Does it make sense to cover DECIMAL128 here as well? http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/common/schema-test.cc@155 PS11, Line 155: As I understand, we don't yet support decimal as a primary key. To express that restriction explicitly, does it make sense to add a test to make sure the schema with decimal type as the key reports an error appropriately? http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/integration-tests/decimal-itest.cc File src/kudu/integration-tests/decimal-itest.cc: http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/integration-tests/decimal-itest.cc@159 PS11, Line 159: Does it make sense to add a test which verifies that out-of-scale values are handled properly by SetDecimal()? http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/integration-tests/decimal-itest.cc@160 PS11, Line 160: } // namespace client Consider adding a test which verifies that boundary decimal values are written and read as expected (for all scale/precision ranges). http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/util/int128.h File src/kudu/util/int128.h: http://gerrit.cloudera.org:8080/#/c/8830/11/src/kudu/util/int128.h@23 PS11, Line 23: <iostream> Is it possible to use <iosfwd> here instead? -- To view, visit http://gerrit.cloudera.org:8080/8830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b06142f43c66973f36376bd2c88ca6f8d9f7632 Gerrit-Change-Number: 8830 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 21:16:35 +0000 Gerrit-HasComments: Yes
