Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9108 )
Change subject: Upgrade to tcmalloc 2.6.3 and enabled sized-deallocation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9108/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9108/1/CMakeLists.txt@610 PS1, Line 610: Exported variants should conform to the C++11 ABI Technically they conform to the pre-C++11 ABI, no? Well, at least all of the exported ABI symbols must adhere to the C++03 symbols; not sure about "hidden" symbols. -- To view, visit http://gerrit.cloudera.org:8080/9108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b76c9d71b29d58f0b6dade3fc33b32d0c3de23b Gerrit-Change-Number: 9108 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 23 Jan 2018 23:16:26 +0000 Gerrit-HasComments: Yes
