Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267 ...................................................................... Patch Set 3: (4 comments) lgtm, just a couple of nits http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@10 PS3, Line 10: cert nit: server TLS certificate http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@11 PS3, Line 11: authenticated nit: 'authentication' or just 'authn' for brevity http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@12 PS3, Line 12: negotiaition nit: seems to be a typo, should be 'negotiation' http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@80 PS3, Line 80: credential nit: credentials -- To view, visit http://gerrit.cloudera.org:8080/9071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72 Gerrit-Change-Number: 9071 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 00:14:29 +0000 Gerrit-HasComments: Yes
