Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 )
Change subject: KUDU-1927: no half-baked responses on ConnectToMaster ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/9052/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9052/8/src/kudu/master/catalog_manager.cc@224 PS8, Line 224: during s/during loading/while reading http://gerrit.cloudera.org:8080/#/c/9052/8/src/kudu/master/catalog_manager.cc@236 PS8, Line 236: extra line http://gerrit.cloudera.org:8080/#/c/9052/8/src/kudu/master/master_cert_authority.h File src/kudu/master/master_cert_authority.h: http://gerrit.cloudera.org:8080/#/c/9052/8/src/kudu/master/master_cert_authority.h@57 PS8, Line 57: Does not require Init() to be called. : // Calling this method does not have side-effects on the instance, i.e. : // even this method has been called on object, it's still necessary : // to call Init() prior to calling SignServerCSR() method. I think this info about Init can be omitted now since it's static. -- To view, visit http://gerrit.cloudera.org:8080/9052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c906863f5f0e1995041281b122135e1b2cd3a4 Gerrit-Change-Number: 9052 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 23:32:10 +0000 Gerrit-HasComments: Yes
