Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9126 )
Change subject: [tests] de-flaking DontEvictIfRemainingConfigIsUnstable ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9126/1/src/kudu/integration-tests/tablet_replacement-itest.cc File src/kudu/integration-tests/tablet_replacement-itest.cc: http://gerrit.cloudera.org:8080/#/c/9126/1/src/kudu/integration-tests/tablet_replacement-itest.cc@149 PS1, Line 149: constexpr auto kHbIntervalSec = 3 * kUnavailableSec; > can we do 3-4 sec instead of 9 sec here? I made it 6 seconds. 3-4 turned to be less reliable in case of TSAN builds. Even with 6 seconds it's about 0.48% failure rate if running TSAN builds with --stress-cpu-threads=16. http://gerrit.cloudera.org:8080/#/c/9126/1/src/kudu/integration-tests/tablet_replacement-itest.cc@159 PS1, Line 159: "--leader_failure_max_missed_heartbeat_periods=30", > per our offline conversation, this can be removed Done -- To view, visit http://gerrit.cloudera.org:8080/9126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb23d71b600a46f7fd6bba56091f884eae24784f Gerrit-Change-Number: 9126 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2018 04:39:49 +0000 Gerrit-HasComments: Yes
