Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9193 )

Change subject: [tests] Add more test coverage for INT128 columns
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9193/2/src/kudu/cfile/cfile-test.cc
File src/kudu/cfile/cfile-test.cc:

http://gerrit.cloudera.org:8080/#/c/9193/2/src/kudu/cfile/cfile-test.cc@553
PS2, Line 553:
> no need for this space between closing brackets anymore; this was fixed in
Done


http://gerrit.cloudera.org:8080/#/c/9193/2/src/kudu/tablet/all_types-scan-correctness-test.cc
File src/kudu/tablet/all_types-scan-correctness-test.cc:

http://gerrit.cloudera.org:8080/#/c/9193/2/src/kudu/tablet/all_types-scan-correctness-test.cc@585
PS2, Line 585:                          // TODO: Uncomment when adding 128 bit 
support to RLE
> Probably worth having a tracking ticket for this since I imagine we won't d
Agreed. Created KUDU-2284 and updated all places where this was used.



--
To view, visit http://gerrit.cloudera.org:8080/9193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3350634e55aad4316036c80d03e95e0acdf64295
Gerrit-Change-Number: 9193
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 02 Feb 2018 18:41:10 +0000
Gerrit-HasComments: Yes

Reply via email to