Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9177 )

Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9177/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:

http://gerrit.cloudera.org:8080/#/c/9177/1/src/kudu/util/metrics.h@434
PS1, Line 434: f 0. Note that some metrics with the value 0
aren't there counters we increment by negative amounts



--
To view, visit http://gerrit.cloudera.org:8080/9177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d2c4640e54c91791fab9c420215bafa3fe8f20
Gerrit-Change-Number: 9177
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Feb 2018 20:45:41 +0000
Gerrit-HasComments: Yes

Reply via email to