Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 )
Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) ...................................................................... Patch Set 32: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.cc@190 PS28, Line 190: delete data_; : data_ = new Data(*other.data_); > All instances of CopyFrom in schema.cc behave this way. The = operator does SGTM: yep, it's better to keep in uniform in that case. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/common/schema.h@91 PS28, Line 91: public: > I was following "convention" of the other structs in this file. Should we d I tried to locate corresponding section in https://google.github.io/styleguide/cppguide.html, but didn't see anything. It's just a nit and if it's inline with the rest of the stuff, it's perfectly fine with me. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc File src/kudu/integration-tests/decimal-itest.cc: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@55 PS28, Line 55: eName = "decimal-ta > Further down I set num_replicas to kNumServers. Ah, ok -- it seems I missed it. -- To view, visit http://gerrit.cloudera.org:8080/8830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b06142f43c66973f36376bd2c88ca6f8d9f7632 Gerrit-Change-Number: 8830 Gerrit-PatchSet: 32 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 21:58:12 +0000 Gerrit-HasComments: Yes
