Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 )
Change subject: Improved logging of DMS flushes ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@669 PS1, Line 669: bytes > can you clarify this as "on disk" Done http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@680 PS1, Line 680: LOG_WITH_PREFIX(INFO) << "Opened new delta block " << block_id.ToString() << " for read"; > I wonder if this log is really useful - seems somewhat redundant with the a Done http://gerrit.cloudera.org:8080/#/c/9204/1/src/kudu/tablet/delta_tracker.cc@727 PS1, Line 727: bytes > can you clarify "in memory" here to contrast from the bytes that we report Done -- To view, visit http://gerrit.cloudera.org:8080/9204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8241a6ae33c22838504aa7007463d11167a22e65 Gerrit-Change-Number: 9204 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 05 Feb 2018 08:47:26 +0000 Gerrit-HasComments: Yes
