Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 )
Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9246/1/src/kudu/consensus/consensus_meta.h File src/kudu/consensus/consensus_meta.h: PS1: > Well, semi WIP, I wanted your opinion but I tend to agree that we should re Yep, overall it LGTM. I think it's a movement in the right direction. By my opinion, once converted into non-thread safe with fake mutex for additional consistency, this class needs a bit of restructuring and cleanup. -- To view, visit http://gerrit.cloudera.org:8080/9246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d086c3fba52826ebe0d3a44842d53ecb6a9265 Gerrit-Change-Number: 9246 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 07 Feb 2018 23:12:48 +0000 Gerrit-HasComments: Yes
