Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9260 )
Change subject: Add additonal form and tests for GetConsensusRole() ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > LGTM, just a small nit/question. http://gerrit.cloudera.org:8080/#/c/9260/1/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/9260/1/src/kudu/consensus/quorum_util-test.cc@287 PS1, Line 287: ASSERT_EQ(NON_PARTICIPANT, GetConsensusRole("D", cstate)); // Illegal. > Does it make sense to add the following cases: Done -- To view, visit http://gerrit.cloudera.org:8080/9260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic28f15c40ce99f89481cb6869d4843cbc024ed48 Gerrit-Change-Number: 9260 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 03:24:35 +0000 Gerrit-HasComments: Yes
