Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 )
Change subject: KUDU-721: [Spark] Add DECIMAL type support ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@308 PS2, Line 308: _: DecimalType > Does DecimalType() means we are only matching for the case when precision i DecimalType() is actually calling unapply(t: DataType) which internally calls t.isInstanceOf[DecimalType]. It's effectively the same as _: DecimalType. Meant to change it here too. will push the update. -- To view, visit http://gerrit.cloudera.org:8080/9213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840 Gerrit-Change-Number: 9213 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 09 Feb 2018 14:35:36 +0000 Gerrit-HasComments: Yes
