Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9269 )
Change subject: Expose RPC method info map and various metrics ...................................................................... Patch Set 4: (2 comments) Thanks for the review. Please see PS4. http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1098 PS3, Line 1098: histogram() > nit: maybe, name it histogram() since it's just an accessor? Done http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1105 PS3, Line 1105: virtual bool IsUntouched() const override { > nit: maybe, drop this method and use the newly introduced one in rpc-bench. Done -- To view, visit http://gerrit.cloudera.org:8080/9269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825 Gerrit-Change-Number: 9269 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sun, 11 Feb 2018 23:07:39 +0000 Gerrit-HasComments: Yes
