Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9263 )

Change subject: Make tcmalloc heap sampling more useful
......................................................................


Patch Set 2:

(3 comments)

I tried this out on my macOS system and the heap samples looked like this:

heap profile:     93: 57580776 [    93: 57580776] @ heap_v2/512000
    14: 13993984 [    14: 13993984] @ 0x10b9dce13 0x7fff57cc9201 0x7fff57cc850b 
0x10d9386f9 0x10d938603 0x10d938c0f 0x10d939579 0x10d932137 0x10d92fbcb 
0x10d93096c 0x10a19f012 0x10a1a09d4 0x10a1a08e4 0x10a1a0810 0x10a18b7c8 
0x10a18a737 0x10a0498ee 0x10a05078b 0x10a04f755 0x10a110ff7 0x10a102d1f 
0x10a1050a9 0x10a104ffc 0x10a104faa 0x10a5f08de 0x10da06ff9 0x10da0206f 
0x10da1da69 0x10da1d9d0 0x10da1d97a 0x10da1d75d
     5:  2621440 [     5:  2621440] @ 0x10b9dce13 0x7fff57cc9201 0x7fff57cc850b 
0x10d9386f9 0x10d938603 0x10d932137 0x10d932aeb 0x10d93377c 0x1099537d2 
0x10a113dfd 0x10a113920 0x10a046164 0x10a10ff46 0x10a100115 0x10a0fef97 
0x10a1050a9 0x10a104ffc 0x10a104faa 0x10a5f08de 0x10da06ff9 0x10da0206f 
0x10da1da69 0x10da1d9d0 0x10da1d97a 0x10da1d75d 0x10b33e198 0x10d9ecb88 
0x7fff57dac6c1 0x7fff57dac56d 0x7fff57dabc5d
     2:   509952 [     2:   509952] @ 0x10b9dccf1 0x7fff57cc9201 0x7fff57cc850b 
0x10d9386f9 0x10d938603 0x10d938c0f 0x10d939579 0x10d932137 0x10d92fbcb 
0x10d93096c 0x10a19f012 0x10a19edc4 0x10a1a28a9 0x10a1a14a1 0x10a1a0e13 
0x10a18b8bf 0x10a18a80a 0x10a0498ee 0x10a05078b 0x10a04f755 0x10a110ff7 
0x10a102d1f 0x10a1050a9 0x10a104ffc 0x10a104faa 0x10a5f08de 0x10da06ff9 
0x10da0206f 0x10da1da69 0x10da1d9d0 0x10da1d97a
     3:      192 [     3:      192] @ 0x10b9dccf1 0x7fff57cc9201 0x7fff57cc850b 
0x7fff55ba8628 0x10a1bd6ce 0x10a049964 0x10a05078b 0x10a04f755 0x10a110ff7 
0x10a102d1f 0x10a1050a9 0x10a104ffc 0x10a104faa 0x10a5f08de 0x10da06ff9 
0x10da0206f 0x10da1da69 0x10da1d9d0 0x10da1d97a 0x10da1d75d 0x10b33e198 
0x10d9ecb88 0x7fff57dac6c1 0x7fff57dac56d 0x7fff57dabc5d
    12: 12464128 [    12: 12464128] @ 0x10b9dce13 0x7fff57cc9201 0x7fff57cc850b 
0x10d9386f9 0x10d938603 0x10d938c0f 0x10d939579 0x10d932137 0x10d92fbcb 
0x10d93096c 0x10a19f012 0x10a19edc4 0x10a1a28a9 0x10a1a14a1 0x10a1a0e13 
0x10a18b8bf 0x10a18a80a 0x10a0498ee 0x10a05078b 0x10a04f755 0x10a110ff7 
0x10a102d1f 0x10a1050a9 0x10a104ffc 0x10a104faa 0x10a5f08de 0x10da06ff9 
0x10da0206f 0x10da1da69 0x10da1d9d0 0x10da1d97a

Is that because it's macOS? If not, how does one read that?

http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/server/pprof_path_handlers.cc
File src/kudu/server/pprof_path_handlers.cc:

http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/server/pprof_path_handlers.cc@104
PS2, Line 104: message with instructions how to enable it
The message (tcmalloc.cc L592) just mentions the TCMALLOC_SAMPLE_PARAMETER 
environment variable and not the gflag.


http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:

http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc@88
PS2, Line 88: heap_sample_parameter
I know this name matches the one that tcmalloc uses, but I'd like a more 
descriptive name. Maybe something like "heap_sample_every_n_bytes"? That sort 
of name has precedents in our logging macros.


http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc@89
PS2, Line 89:  N
What's N? I think this would also be fixed with a better name and adjusted 
description.



--
To view, visit http://gerrit.cloudera.org:8080/9263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939c2f01f17ceb4b9520bb566f66463952b2a255
Gerrit-Change-Number: 9263
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 18:16:12 +0000
Gerrit-HasComments: Yes

Reply via email to