Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9253 )
Change subject: KUDU-2291 (part 2): Add a /stacks page ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Nits only, I'd be fine with merging as-is. http://gerrit.cloudera.org:8080/#/c/9253/3/src/kudu/integration-tests/linked_list-test-util.h File src/kudu/integration-tests/linked_list-test-util.h: http://gerrit.cloudera.org:8080/#/c/9253/3/src/kudu/integration-tests/linked_list-test-util.h@315 PS3, Line 315: master_pages.emplace_back("/metrics"); : master_pages.emplace_back("/masters"); : master_pages.emplace_back("/tables"); : master_pages.emplace_back("/dump-entities"); : master_pages.emplace_back("/tablet-servers"); : master_pages.emplace_back("/mem-trackers"); : master_pages.emplace_back("/stacks"); :Puts Adar hat on: Could you sort these in alphabetical order? http://gerrit.cloudera.org:8080/#/c/9253/3/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/9253/3/src/kudu/server/default_path_handlers.cc@162 PS3, Line 162: Status s = ListThreads(&tids); This just returns Status::OK() on macOS, so the stacks page just says "Collected stacks from 0 threads in 0.000s". Not a big deal, but ideally on macOS there'd be a note saying stack collection isn't supported. -- To view, visit http://gerrit.cloudera.org:8080/9253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f6d50d44e40fd51357fdbfd8f9ba2ebaa724b Gerrit-Change-Number: 9253 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 20:45:33 +0000 Gerrit-HasComments: Yes
