Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 )
Change subject: KUDU-2291 (part 3): use futex to speed up stack collection ...................................................................... Patch Set 3: Code-Review+1 (1 comment) LGTM with one comment nit, but I'd like Mike to take a look since futex semantics are new to me. http://gerrit.cloudera.org:8080/#/c/9254/3/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9254/3/src/kudu/util/debug-util.cc@331 PS3, Line 331: a few iterations of the loop nit: The loop is gone. -- To view, visit http://gerrit.cloudera.org:8080/9254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb772f0607275ec340c7f38be05347fc14820cbd Gerrit-Change-Number: 9254 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 20:55:10 +0000 Gerrit-HasComments: Yes