Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9312 )
Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9312/2/src/kudu/rpc/serialization.cc File src/kudu/rpc/serialization.cc: http://gerrit.cloudera.org:8080/#/c/9312/2/src/kudu/rpc/serialization.cc@121 PS2, Line 121: CodedInputStream in(buf.data(), buf.size()); > isn't this just the stream used for parsing the header, not the main messag The Skip() that we use to verify that the total size of the message (including sidecars) is big enough hits the 64MB limit and returns false. (Given how the Skip() is being used, it is really just a range check. Changing it to a range check not built around CodedInputStream also would fix the problem.) http://gerrit.cloudera.org:8080/#/c/9312/2/src/kudu/rpc/serialization.cc@148 PS2, Line 148: if (PREDICT_FALSE(!in.Skip(main_msg_len))) { This is the call that fails. -- To view, visit http://gerrit.cloudera.org:8080/9312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d3f3ca6ec0aa8be0e67e6a13c4b560c9d2c63a Gerrit-Change-Number: 9312 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:19:26 +0000 Gerrit-HasComments: Yes
