Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9316 )
Change subject: [tools] Fail ksck if fetching consensus state fails ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9316/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/9316/1/src/kudu/tools/ksck.cc@215 PS1, Line 215: s = ts->FetchConsensusState(); : if (!s.ok()) { : Warn() << Substitute("Errors gathering consensus info for Tablet Server $0: $1", : ts->ToString(), s.ToString()) << endl; : } : } : return s; > I'm not sure you want to return status from the FetchConsensusState() here We do return an error if any FetchConsensusState fails. ConnectToTabletServer is run against every TS off of a thread pool. Each failure will produce the warning above, and additionally increment a bad_servers count. If bad_servers > 0, then we fail ksck with a generic error, so we get the specific errors for each TS that had a failure, plus the overall failure of ksck. -- To view, visit http://gerrit.cloudera.org:8080/9316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3efc9342c3cb3f9652bb8c9789fe20ecf12ff55 Gerrit-Change-Number: 9316 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 14 Feb 2018 00:39:34 +0000 Gerrit-HasComments: Yes
