David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/16/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8804/16/src/kudu/tserver/tablet_service.cc@2163 PS16, Line 2163: (propagation ts + 1) should not > As we update the clock based on propagated timestamp at L2140, if (propagat Maybe we should just add that explanation to the docs? Also: obvious while we have these things in context, but likely worth mentioning for the documentation value is that "clean" timestamp is, by definition in the past. Suggestion, something like: There is no need to validate if the chosen timestamp is too far in the future, as : - MVCC's 'clean' ts is by definition in the past (it's maximally bounded by safe time). - "propagated" ts was used to update the clock above and the update would have returned an error if the the timestamp was too far in the future. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 16 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 21 Feb 2018 00:42:13 +0000 Gerrit-HasComments: Yes
