David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9235 )

Change subject: docs: improvements to transaction semantics
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:

http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc@214
PS2, Line 214: However this API is considered as a means to control locality, 
never to be used for
             : correctness. Each scan mode should hold the corresponding 
consistency guarantees,
             : no matter which replica is selected.
nit move this inside the note above? also maybe rephrase to:

Kudu also provides replica selection API for users to choose at which replica 
the scan should be performed:

Java Client:: Call `KuduScannerBuilder#replicaSelection(...)`
{cpp} Client:: Call `KuduScanner::SetSelection(...)`

This API is a means to control locality and, in some cases, latency. The 
replica selection API has no effect on the consistency guarantees, which will 
hold no matter which replica is selected.



--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 18:42:01 +0000
Gerrit-HasComments: Yes

Reply via email to